Emit Quent events for cudf-polars memory reservation. - #24038
Draft
TomAugspurger wants to merge 4 commits into
Draft
Emit Quent events for cudf-polars memory reservation.#24038TomAugspurger wants to merge 4 commits into
TomAugspurger wants to merge 4 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
Python
TomAugspurger
commented
Sep 8, 2026
TomAugspurger
added
non-breaking
…+memory-reservation
TomAugspurger
commented
Sep 10, 2026
| __all__ = ["MemoryReservationPurpose", "reserve_memory_traced"] | ||
|
|
||
|
|
||
| async def reserve_memory_traced( |
Contributor
Author
There was a problem hiding this comment.
I'm noticing a pattern here: we want to perform some operation using another library like kvikio or rapidsmpf and record something about its operation (using some context that only cudf-polars has, like the current operator being worked on). So I've added a wrapper that calls the underlying library and then updates the metrics.
To capture all the memory reservations, we need to ensure that every call to rapidsmpf's reserve_memory goes through our reserve_memory_traced.
Contributor
Author
|
/ok to test 6feda06 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates our emitted Quent telemetry to better track memory reservations. I've added a wrapper around
rapidsmpf.streaming.core.memory_reserve_or_wait.reserve_memorythat includesLike any other Quent event, this can be tied back to an individual Operator (cudf-polars Actor).